> On June 17, 2014, 1:35 a.m., Vinod Kone wrote: > > 3rdparty/libprocess/include/process/event.hpp, line 193 > > <https://reviews.apache.org/r/22426/diff/1/?file=606519#file606519line193> > > > > why this change? > > Jiang Yan Xu wrote: > Otherwise the implicitly-declared copy assignment operator is deleted. > http://en.cppreference.com/w/cpp/language/as_operator#Deleted_implicitly-declared_copy_assignment_operator
Vinod makes a good point, we should leave a comment here that says something along the lines of "instance variable is not const so that struct is default copyable". - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22426/#review45882 ----------------------------------------------------------- On June 10, 2014, 6:16 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22426/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 6:16 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1444 > https://issues.apache.org/jira/browse/MESOS-1444 > > > Repository: mesos-git > > > Description > ------- > > This is necessary for https://reviews.apache.org/r/22427, Master needs to > bind these events as arguments when deferring them. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/event.hpp > e30a4d4aa7d8235bc3fb41a6ae1684b89d351679 > > Diff: https://reviews.apache.org/r/22426/diff/ > > > Testing > ------- > > Tested along with https://reviews.apache.org/r/22427 > > > Thanks, > > Jiang Yan Xu > >
