----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22702/#review46095 -----------------------------------------------------------
Ship it! It's clear that there are other opportunities to just use Subprocess::PATH too (for example with the fetch code), but that would require some slight cleanup around doing 'chown' (or moving that functionality to Subprocess too). src/launcher/launcher.cpp <https://reviews.apache.org/r/22702/#comment81250> Why not: Subprocess::FD(stdout), Subprocess::FD(stderr), Then kill the io::redirect below? - Benjamin Hindman On June 17, 2014, 11:32 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22702/ > ----------------------------------------------------------- > > (Updated June 17, 2014, 11:32 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1487 > https://issues.apache.org/jira/browse/MESOS-1487 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/launcher/launcher.cpp 1d352b6 > src/linux/perf.cpp bc31db5 > src/slave/containerizer/external_containerizer.cpp b5d0c4c > src/slave/containerizer/mesos_containerizer.cpp 4d97d49 > src/tests/slave_tests.cpp 9178e01 > > Diff: https://reviews.apache.org/r/22702/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
