----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22749/#review46109 -----------------------------------------------------------
Ship it! Looks good. I think we might want more overloads at some point that lets us mix and match flags, stdin, stderr, stdout, etc, but we can do that later. 3rdparty/libprocess/src/subprocess.cpp <https://reviews.apache.org/r/22749/#comment81276> The long term solution here is probably to have an array of strings and use a different exec variant. Maybe for the flags case we can assume that 'command' is really 'argv0'? Perhaps suggest this in the TODO so one can circle back. - Benjamin Hindman On June 18, 2014, 6:45 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22749/ > ----------------------------------------------------------- > > (Updated June 18, 2014, 6:45 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > See summary. This patch only updated references in libprocess. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/subprocess.hpp e93608a > 3rdparty/libprocess/src/subprocess.cpp 78fa1ec > 3rdparty/libprocess/src/tests/subprocess_tests.cpp 1cb1ce3 > > Diff: https://reviews.apache.org/r/22749/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
