> On June 17, 2014, 5:40 p.m., Ben Mahler wrote: > > include/mesos/scheduler.hpp, lines 448-449 > > <https://reviews.apache.org/r/22703/diff/1/?file=611942#file611942line448> > > > > How about: > > > > // Unique identifier for the SchedulerProcess PID. > > UUID uuid; > > > > Or > > > > // Scheduler process id. > > string schedulerId; > > > > The latter seems a bit more direct, we would construct the id only once > > as "scheduler-UUID". Up to you.
we still construct it twice as there are two constructors, but yes it is much more direct. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22703/#review46022 ----------------------------------------------------------- On June 18, 2014, 12:49 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22703/ > ----------------------------------------------------------- > > (Updated June 18, 2014, 12:49 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1374 > https://issues.apache.org/jira/browse/MESOS-1374 > > > Repository: mesos-git > > > Description > ------- > > Adding a delegate to the process::initialize call requires choosing the UUID > before creating the SchedulerProcess. > > While in the code, I updated the order of private/protected regions. > > > Diffs > ----- > > include/mesos/scheduler.hpp d224945f591b1ec0f62fc936822cd3efd07b9739 > src/sched/sched.cpp a82a39d9fd713fe17a0bc84675f0562ea7564869 > > Diff: https://reviews.apache.org/r/22703/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
