----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22687/#review46115 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/src/http.cpp <https://reviews.apache.org/r/22687/#comment81300> Seems a bit odd to have this in between the addr struct and the connect call, how about placing it in the beginning or above the addr struct declaration? 3rdparty/libprocess/src/http.cpp <https://reviews.apache.org/r/22687/#comment81299> Looks like we don't need the explicit "string(...)" since we're constructing it with a + constructed string, right? - Ben Mahler On June 18, 2014, 7:26 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22687/ > ----------------------------------------------------------- > > (Updated June 18, 2014, 7:26 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1500 > https://issues.apache.org/jira/browse/MESOS-1500 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/src/http.cpp eb20380d6e3b3a027f03a85a0a572cae1939e1f9 > > Diff: https://reviews.apache.org/r/22687/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
