-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22715/
-----------------------------------------------------------
(Updated June 20, 2014, 6:33 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Also fixed scheduler.pb.h and containerizer.pb.h.
Bugs: MESOS-1504
https://issues.apache.org/jira/browse/MESOS-1504
Repository: mesos-git
Description
-------
Updated the <mesos.pb.h> include to <mesos/mesos.pb.h>, had to ensure that the
file was placed inside the include folder in the build directory as well.
The hack here is that we need to move the .pb.cc files out of the build include
directory.
Diffs (updated)
-----
include/mesos/containerizer/containerizer.hpp
aefdb6f1856307f0267598946e3d6954c464efb2
include/mesos/mesos.hpp.in 2d4310cc9ec40041cdb1f313a52522882ad2aeb5
include/mesos/scheduler/scheduler.hpp
7aebebfff6dafe8100c8814f064c0113065e1ebb
src/Makefile.am b1b7d2de145294cd26e39a504e4f8568f25da40b
src/python/setup.py.in 0c6e26489367835813cf90a9baf39f5971a7556d
Diff: https://reviews.apache.org/r/22715/diff/
Testing
-------
$ cat test.cpp
#include <mesos/mesos.hpp>
int main() { return 0; }
Before (issue with mesos include):
$ g++ test.cpp -I /usr/local/include
In file included from test.cpp:1:
/usr/local/include/mesos/mesos.hpp:22:10: error: 'mesos.pb.h' file not found
with <angled> include; use "quotes" instead
#include <mesos.pb.h> // ONLY USEFUL AFTER RUNNING PROTOC.
^~~~~~~~~~~~
"mesos.pb.h"
In file included from test.cpp:1:
In file included from /usr/local/include/mesos/mesos.hpp:22:
/usr/local/include/mesos/mesos.pb.h:9:10: fatal error:
'google/protobuf/stubs/common.h' file not found
#include <google/protobuf/stubs/common.h>
^
2 errors generated.
After (past the mesos include):
$ g++ test.cpp -I /usr/local/include
In file included from test.cpp:1:
In file included from /usr/local/include/mesos/mesos.hpp:22:
/usr/local/include/mesos/mesos.pb.h:9:10: fatal error:
'google/protobuf/stubs/common.h' file not found
#include <google/protobuf/stubs/common.h>
^
1 error generated.
Thanks,
Ben Mahler
