----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22777/#review46416 -----------------------------------------------------------
Ship it! include/mesos/mesos.proto <https://reviews.apache.org/r/22777/#comment81806> s/them./them,/ src/master/master.cpp <https://reviews.apache.org/r/22777/#comment81807> s/about/with/ - Vinod Kone On June 23, 2014, 4:12 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22777/ > ----------------------------------------------------------- > > (Updated June 23, 2014, 4:12 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1492 > https://issues.apache.org/jira/browse/MESOS-1492 > > > Repository: mesos-git > > > Description > ------- > > In current previous design and implementation of framework rate limiting, > Master only throttles frameworks specified explicitly in RateLimits. > Frameworks not specified are not throttled. > > We can add an {{optional double aggregate_default_qps}} to RateLimits > protobuf and throttle all of the unspecified frameworks together using one > RateLimiter at the {{aggregate_default_qps}} rate. > > This allows the Mesos cluster operator to safeguard the Master from > unexpected frameworks and it's optional. > > > Diffs > ----- > > include/mesos/mesos.proto 2f6be059d3626663b73417863b42505c36f0446f > src/master/flags.hpp 47bb0dc04504fc847cc02fa97eb0d045a8835c9e > src/master/master.hpp f4cdb26567a316755dbb55da239277bb370bf696 > src/master/master.cpp 00152f5b889a2d10255835779b66c9ed26df9a2b > src/tests/rate_limiting_tests.cpp 9a544618e70e7ce3091fa303597eb1bb3d161bf9 > > Diff: https://reviews.apache.org/r/22777/diff/ > > > Testing > ------- > > Added/modified tests for the default limiter. > make check. > > > Thanks, > > Jiang Yan Xu > >
