----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22831/#review46426 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/src/subprocess.cpp <https://reviews.apache.org/r/22831/#comment81812> Feel free to not make this a const & and just do the copy up front. 3rdparty/libprocess/src/subprocess.cpp <https://reviews.apache.org/r/22831/#comment81814> Same here, feel free to do the copy up front. - Benjamin Hindman On June 21, 2014, 4:49 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22831/ > ----------------------------------------------------------- > > (Updated June 21, 2014, 4:49 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1528 > https://issues.apache.org/jira/browse/MESOS-1528 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/subprocess.hpp d6e2c1f > 3rdparty/libprocess/src/subprocess.cpp 6ac7b5b > 3rdparty/libprocess/src/tests/subprocess_tests.cpp 7dfa384 > > Diff: https://reviews.apache.org/r/22831/diff/ > > > Testing > ------- > > make check > 3rdparty/libprocess/tests --gtest_filter=*Subprocess* --gtest_repeat=100 > > Both Linux and Mac > > > Thanks, > > Jie Yu > >
