----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22897/#review46481 -----------------------------------------------------------
Ship it! Please go ahead and commit. 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/22897/#comment81864> How about this, seems a bit more straightforward: if (version != other.version) { return version < other.version; } else if (major != other.major) { return major < other.major; } else { return minor < other.minor; } 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/22897/#comment81865> Could we do it in the other order? < then == just like in the <= syntax? :) - Ben Mahler On June 23, 2014, 11:25 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22897/ > ----------------------------------------------------------- > > (Updated June 23, 2014, 11:25 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Used for upcoming review to compare to minimum required release for perf. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 0529f88c1f132aa58f027a97f769c132949207d7 > > Diff: https://reviews.apache.org/r/22897/diff/ > > > Testing > ------- > > none. > > > Thanks, > > Ian Downes > >
