> On June 25, 2014, 1:26 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp, line 145 > > <https://reviews.apache.org/r/22764/diff/4/?file=614726#file614726line145> > > > > Don't you need to shift the argv array before you pass it for flag > > loading? Seems like you don't want to pass the 'subcommand' part of argv. > > Jie Yu wrote: > It's OK. It'll just be ignored.
In fact, I changed it to flags->load(prefix, argc - 1, argv + 1); - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22764/#review46596 ----------------------------------------------------------- On June 21, 2014, 4:53 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22764/ > ----------------------------------------------------------- > > (Updated June 21, 2014, 4:53 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1511 > https://issues.apache.org/jira/browse/MESOS-1511 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am eac7ab5 > 3rdparty/libprocess/3rdparty/stout/include/stout/subcommand.hpp > PRE-CREATION > 3rdparty/libprocess/src/tests/subprocess_tests.cpp 7dfa384 > src/Makefile.am fd2c80f > src/launcher/launcher.hpp 35cdc69 > src/launcher/launcher.cpp 872e2e8 > src/launcher/main.cpp b497e98 > src/tests/environment.cpp 21b9d1d > src/tests/launcher_tests.cpp e293cc5 > > Diff: https://reviews.apache.org/r/22764/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
