> On June 25, 2014, 7:29 p.m., Vinod Kone wrote: > > src/linux/cgroups.cpp, line 397 > > <https://reviews.apache.org/r/22979/diff/1/?file=617497#file617497line397> > > > > How about > > > > "Recent kernels will cause operations to fail if 'endl' is appended to > > the control file." > > > > I'm assuming it is backwards compatible with older kernels?
The endln was never a convention, but earlier releases never had an issue with it. https://access.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Resource_Management_Guide/ch-Using_Control_Groups.html Newer release appear to have issue with it. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22979/#review46672 ----------------------------------------------------------- On June 25, 2014, 7:26 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22979/ > ----------------------------------------------------------- > > (Updated June 25, 2014, 7:26 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-1195 > https://issues.apache.org/jira/browse/MESOS-1195 > > > Repository: mesos-git > > > Description > ------- > > Minor update to remove the endln appending to cgroup writes. This causes > issues in later kernels, I uncovered it in rawhide. > > > Diffs > ----- > > src/linux/cgroups.cpp 5472eb8 > > Diff: https://reviews.apache.org/r/22979/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >
