----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22598/#review46816 -----------------------------------------------------------
I think in most of the cases, if you need hostIP, you will need eth0 name too. So I don't think this function is quite useful. I would suggest postpone this patch until we see a use case. - Jie Yu On June 27, 2014, 12:12 a.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22598/ > ----------------------------------------------------------- > > (Updated June 27, 2014, 12:12 a.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > Routing: added an interface to get host public IP. > > > Diffs > ----- > > src/linux/routing/utils.hpp a3d914a > src/linux/routing/utils.cpp 80b62d0 > src/tests/routing_tests.cpp 0e8f61a > > Diff: https://reviews.apache.org/r/22598/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Chi Zhang > >
