----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21734/#review46961 -----------------------------------------------------------
Ship it! Looks great! Minor cleanup, then I'd call it ready to commit. src/tests/fetcher_tests.cpp <https://reviews.apache.org/r/21734/#comment82531> ASSERT_SOME(os::mkdir(fromDir)); src/tests/fetcher_tests.cpp <https://reviews.apache.org/r/21734/#comment82532> ASSERT_SOME(mkdir) src/tests/utils.hpp <https://reviews.apache.org/r/21734/#comment82533> Remove the extra line. - Adam B On June 28, 2014, 12:56 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21734/ > ----------------------------------------------------------- > > (Updated June 28, 2014, 12:56 a.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-390 > https://issues.apache.org/jira/browse/MESOS-390 > > > Repository: mesos-git > > > Description > ------- > > Handling file:// in the fetcher, and also handle case when localhost is used. > > > Diffs > ----- > > src/Makefile.am 9027927 > src/launcher/fetcher.cpp c4425eb > src/tests/fetcher_tests.cpp PRE-CREATION > src/tests/utils.hpp 5c86fd4 > > Diff: https://reviews.apache.org/r/21734/diff/ > > > Testing > ------- > > Added unit tests to test file:// and file://localhost. > make check. > > > Thanks, > > Timothy Chen > >
