----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23214/#review47162 -----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/23214/#comment82756> Remove ':' src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/23214/#comment82757> Remove ':' and use 'pid' (instead of 'PID') src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/23214/#comment82758> network isolator src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/23214/#comment82759> Remove ':' src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/23214/#comment82762> What if network isolation is not available (e.g., libnl is too old)? Should we check for that? src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/23214/#comment82760> Why not move this down. You can do: slave::Flags flags2 = CreateSlaveFlags(); src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/23214/#comment82761> What if cgroups is not available when testing (e.g. on Mac?) src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/23214/#comment82764> Probably say: this is to verify the case where one task is running w/o network isolator and another task is running w/ network isolator. - Jie Yu On July 1, 2014, 9:22 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23214/ > ----------------------------------------------------------- > > (Updated July 1, 2014, 9:22 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone. > > > Bugs: https://issues.apache.org/jira/browse/MESOS-1557 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1557 > > > Repository: mesos-git > > > Description > ------- > > This eases deployment where a slave could be upgraded to use Network Isolator > without removing all the existing tasks. > > - Added a new test. > - Moved all portmapping tests to a new file. > > > Diffs > ----- > > src/Makefile.am e3ff6d7 > src/slave/containerizer/isolators/network/port_mapping.cpp a326653 > src/tests/isolator_tests.cpp 4650f97 > src/tests/port_mapping_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/23214/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
