----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23216/#review47220 -----------------------------------------------------------
src/examples/low_level_scheduler_pthread.cpp <https://reviews.apache.org/r/23216/#comment82875> s/unblock/Unblock/ src/examples/low_level_scheduler_pthread.cpp <https://reviews.apache.org/r/23216/#comment82877> do we need to protect this via mutex? afaict, all the callbacks (connected, detected and received) are already synchronized by Mesos. src/examples/low_level_scheduler_pthread.cpp <https://reviews.apache.org/r/23216/#comment82878> ditto. here. src/examples/low_level_scheduler_pthread.cpp <https://reviews.apache.org/r/23216/#comment82899> ditto. src/examples/low_level_scheduler_pthread.cpp <https://reviews.apache.org/r/23216/#comment82902> s/Launch *launch/Launch* launch/ We keep the pointers "*" close to the types instead of the variables. src/examples/low_level_scheduler_pthread.cpp <https://reviews.apache.org/r/23216/#comment82903> ditto. s/Acknowledge *ack/Acknowledge* ack/ src/examples/low_level_scheduler_pthread.cpp <https://reviews.apache.org/r/23216/#comment82914> This method name is misleading because it is not actually doing reliable registration. It is just sending a registration request once. Some other method (wait()) is orchestrating the reliable part. It is probably cleaner to move the while loop from wait() to here to do reliable registration. Is there a reason why wait() needs a while loop? src/examples/low_level_scheduler_pthread.cpp <https://reviews.apache.org/r/23216/#comment82904> s/state/state./ src/examples/low_level_scheduler_pthread.cpp <https://reviews.apache.org/r/23216/#comment82861> 2 blank lines between outer elements. src/examples/low_level_scheduler_pthread.cpp <https://reviews.apache.org/r/23216/#comment82862> 2 blank lines between outer elements. - Vinod Kone On July 1, 2014, 11:05 p.m., Zuyu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23216/ > ----------------------------------------------------------- > > (Updated July 1, 2014, 11:05 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Added the low level scheduler example using pthread. > > > Diffs > ----- > > src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc > src/examples/low_level_scheduler_pthread.cpp PRE-CREATION > src/tests/examples_tests.cpp 2b554d72f0058a68f589719373f3d3e37a3a7ba3 > src/tests/low_level_scheduler_pthread_test.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/23216/diff/ > > > Testing > ------- > > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from ExamplesTest > [ RUN ] ExamplesTest.LowLevelSchedulerPthread > [ OK ] ExamplesTest.LowLevelSchedulerPthread (1655 ms) > [----------] 1 test from ExamplesTest (1655 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (1669 ms total) > [ PASSED ] 1 test. > > > Thanks, > > Zuyu Zhang > >
