-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23443/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Jie Yu.


Bugs: MESOS-1533
    https://issues.apache.org/jira/browse/MESOS-1533


Repository: mesos-git


Description
-------

Currently the health check tests are disabled as it was flaky. Part of the 
reason is that all assertions was EXPECTs instead of ASSERTs so it will 
continue to execute. 
Another issue was it's currently discovering the path to launch health check 
executable from the command executor main argv[0] path.
However, the correct path is to launch the generated script that does library 
path resolution, which is the parent of .libs.

Also changed the command executor to also include the health state when it 
kills the task due to unhealthy checks.


Diffs
-----

  src/launcher/executor.cpp 9c80848 
  src/tests/health_check_tests.cpp 44711fd 

Diff: https://reviews.apache.org/r/23443/diff/


Testing
-------

make check


Thanks,

Timothy Chen

Reply via email to