----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23518/#review47804 -----------------------------------------------------------
Ship it! src/launcher/executor.cpp <https://reviews.apache.org/r/23518/#comment84024> Period at end of sentence please. ;-) - Benjamin Hindman On July 15, 2014, 7:33 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23518/ > ----------------------------------------------------------- > > (Updated July 15, 2014, 7:33 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Previous fix for STDIN only fixes the health check command not passing in > STDIN pipe by reading file STDIN. > However the health check command is still getting STDIN piped as the command > executor is creating a PIPE to STDIN when launching health check. > To really fix this we need to also fix not passing anything to STDIN when > launching health check. > > > Diffs > ----- > > src/launcher/executor.cpp 9c80848 > > Diff: https://reviews.apache.org/r/23518/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
