> On July 17, 2014, 12:55 a.m., Benjamin Hindman wrote: > > To Vinod's point, I think adding a comment where you declare the > > Owned<Promise<Nothing>> (at the top of the function) that explains that you > > need to grab this but set it outside of the critical section because > > setting it might trigger callbacks that try to reacquire the lock would be > > great!
Good point, let's also add the same comment to queue.hpp since it already does this without comment. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23592/#review47973 ----------------------------------------------------------- On July 16, 2014, 11:35 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23592/ > ----------------------------------------------------------- > > (Updated July 16, 2014, 11:35 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/mutex.hpp 35589d9 > > Diff: https://reviews.apache.org/r/23592/diff/ > > > Testing > ------- > > 3rdparty/libprocess/tests --gtest_filter=*Mutex* --gtest_repeat=1000 > > > Thanks, > > Jie Yu > >
