----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23659/#review48057 -----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/23659/#comment84325> not sure if this is a good place to use VLOG instead? - Chi Zhang On July 17, 2014, 8:47 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23659/ > ----------------------------------------------------------- > > (Updated July 17, 2014, 8:47 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-1610 > https://issues.apache.org/jira/browse/MESOS-1610 > > > Repository: mesos-git > > > Description > ------- > > See summary and ticket. The 'isolate()' can fail at any point if the child > process dies. The 'cleanup' should tolerate this and do best effort cleanup. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.cpp 03fca2b > > Diff: https://reviews.apache.org/r/23659/diff/ > > > Testing > ------- > > make check > sudo make check > > > Thanks, > > Jie Yu > >
