> On July 16, 2014, 8:24 p.m., Timothy St. Clair wrote: > > 3rdparty/libprocess/Makefile.am, line 79 > > <https://reviews.apache.org/r/23535/diff/2/?file=633594#file633594line79> > > > > Should probably verify that removing from sources doesn't break > > incremental builds. > > > > e.g. change a header and it causes a libprocess rebuild.
confirmed that this doesn't break incremental builds. i changed process/gc.hpp and only objects that needed them were re-compiled and re-linked. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23535/#review47939 ----------------------------------------------------------- On July 16, 2014, 7:47 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23535/ > ----------------------------------------------------------- > > (Updated July 16, 2014, 7:47 p.m.) > > > Review request for mesos, Benjamin Hindman and Timothy St. Clair. > > > Bugs: MESOS-1595 > https://issues.apache.org/jira/browse/MESOS-1595 > > > Repository: mesos-git > > > Description > ------- > > make install now also installs libprocess headers. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am e2034d8a51247f1b6a9e5be51e5ef5480ce2bee0 > 3rdparty/libprocess/configure.ac f972477a855f9de7d9eb04f99b7e8e65f6237374 > 3rdparty/libprocess/include/Makefile.am PRE-CREATION > > Diff: https://reviews.apache.org/r/23535/diff/ > > > Testing > ------- > > make distcheck > > make install > > $ ll /usr/local/include/mesos/ > total 560 > drwxr-xr-x 2 root root 4096 Jul 16 01:47 containerizer > -rw-r--r-- 1 root root 9894 Jul 16 01:47 executor.hpp > -rw-r--r-- 1 root root 1054 Jul 16 01:47 mesos.hpp > -rw-r--r-- 1 root root 440981 Jul 16 01:47 mesos.pb.h > -rw-r--r-- 1 root root 25135 Jul 16 01:47 mesos.proto > -rw-r--r-- 1 root root 12056 Jul 16 01:47 resources.hpp > drwxr-xr-x 2 root root 4096 Jul 16 01:47 scheduler > -rw-r--r-- 1 root root 19299 Jul 16 01:47 scheduler.hpp > -rw-r--r-- 1 root root 2948 Jul 16 01:47 values.hpp > > > $ ll /usr/local/include/process/ > total 616 > -rw-r--r-- 1 root root 12809 Jul 16 01:42 async.hpp > drwxr-xr-x 2 root root 4096 Jul 16 01:42 c+11 > -rw-r--r-- 1 root root 3724 Jul 16 01:42 check.hpp > -rw-r--r-- 1 root root 915 Jul 16 01:42 clock.hpp > -rw-r--r-- 1 root root 6329 Jul 16 01:42 collect.hpp > -rw-r--r-- 1 root root 1423 Jul 16 01:42 counter.hpp > -rw-r--r-- 1 root root 22218 Jul 16 01:42 defer.hpp > -rw-r--r-- 1 root root 6157 Jul 16 01:42 deferred.hpp > -rw-r--r-- 1 root root 5400 Jul 16 01:42 delay.hpp > -rw-r--r-- 1 root root 21150 Jul 16 01:42 dispatch.hpp > -rw-r--r-- 1 root root 4575 Jul 16 01:42 event.hpp > -rw-r--r-- 1 root root 12138 Jul 16 01:42 executor.hpp > -rw-r--r-- 1 root root 638 Jul 16 01:42 filter.hpp > -rw-r--r-- 1 root root 43688 Jul 16 01:42 future.hpp > -rw-r--r-- 1 root root 1075 Jul 16 01:42 gauge.hpp > -rw-r--r-- 1 root root 829 Jul 16 01:42 gc.hpp > -rw-r--r-- 1 root root 10783 Jul 16 01:42 gmock.hpp > -rw-r--r-- 1 root root 11508 Jul 16 01:42 gtest.hpp > -rw-r--r-- 1 root root 23366 Jul 16 01:42 help.hpp > -rw-r--r-- 1 root root 15958 Jul 16 01:42 http.hpp > -rw-r--r-- 1 root root 360 Jul 16 01:42 id.hpp > -rw-r--r-- 1 root root 638 Jul 16 01:42 internal.hpp > -rw-r--r-- 1 root root 3074 Jul 16 01:42 io.hpp > -rw-r--r-- 1 root root 817 Jul 16 01:42 latch.hpp > -rw-r--r-- 1 root root 3704 Jul 16 01:42 limiter.hpp > -rw-r--r-- 1 root root 2811 Jul 16 01:42 logging.hpp > -rw-r--r-- 1 root root 278 Jul 16 01:42 message.hpp > -rw-r--r-- 1 root root 1919 Jul 16 01:42 metric.hpp > -rw-r--r-- 1 root root 2250 Jul 16 01:42 metrics.hpp > -rw-r--r-- 1 root root 5160 Jul 16 01:42 mime.hpp > -rw-r--r-- 1 root root 1615 Jul 16 01:42 mutex.hpp > -rw-r--r-- 1 root root 952 Jul 16 01:42 once.hpp > -rw-r--r-- 1 root root 3368 Jul 16 01:42 owned.hpp > -rw-r--r-- 1 root root 2360 Jul 16 01:42 pid.hpp > -rw-r--r-- 1 root root 10771 Jul 16 01:42 process.hpp > -rw-r--r-- 1 root root 3230 Jul 16 01:42 profiler.hpp > -rw-r--r-- 1 root root 21008 Jul 16 01:42 protobuf.hpp > -rw-r--r-- 1 root root 1701 Jul 16 01:42 queue.hpp > -rw-r--r-- 1 root root 594 Jul 16 01:42 reap.hpp > -rw-r--r-- 1 root root 2647 Jul 16 01:42 run.hpp > -rw-r--r-- 1 root root 5676 Jul 16 01:42 sequence.hpp > -rw-r--r-- 1 root root 3224 Jul 16 01:42 shared.hpp > -rw-r--r-- 1 root root 2103 Jul 16 01:42 socket.hpp > -rw-r--r-- 1 root root 2469 Jul 16 01:42 statistics.hpp > -rw-r--r-- 1 root root 7042 Jul 16 01:42 subprocess.hpp > -rw-r--r-- 1 root root 4834 Jul 16 01:42 system.hpp > -rw-r--r-- 1 root root 2997 Jul 16 01:42 time.hpp > -rw-r--r-- 1 root root 1573 Jul 16 01:42 timeout.hpp > -rw-r--r-- 1 root root 1659 Jul 16 01:42 timer.hpp > -rw-r--r-- 1 root root 8974 Jul 16 01:42 timeseries.hpp > > > Thanks, > > Vinod Kone > >
