----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23695/#review48278 -----------------------------------------------------------
Ship it! src/examples/load_generator_framework.cpp <https://reviews.apache.org/r/23695/#comment84684> it seems a bit weird to do this here. why not set secret to flags.secret() in an else statement above? that seems more clear. - Vinod Kone On July 18, 2014, 10:29 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23695/ > ----------------------------------------------------------- > > (Updated July 18, 2014, 10:29 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1590 > https://issues.apache.org/jira/browse/MESOS-1590 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/examples/load_generator_framework.cpp > f74ebce9f33c924832841eb5bac1fb33a289169e > > Diff: https://reviews.apache.org/r/23695/diff/ > > > Testing > ------- > > Ran the program and had it read a password file. > > > Thanks, > > Jiang Yan Xu > >
