> On July 22, 2014, 1:42 a.m., Vinod Kone wrote: > > src/tests/health_check_tests.cpp, line 213 > > <https://reviews.apache.org/r/23772/diff/2/?file=637711#file637711line213> > > > > Sorry, didn't understand the description. What is the bug?
Basically the test expects 4 health failures and then a Task kill message. However if the task command itself finishes, then the health process itself is reaped and no more health checks will be sent. The task I'm running is simply a sleep, so I think the CI machines that are slower might take more than 20 seconds since task launched to setup health and start getting all messages. I changed it to sleep 2 minutes instead of 20 seconds. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23772/#review48326 ----------------------------------------------------------- On July 21, 2014, 9:10 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23772/ > ----------------------------------------------------------- > > (Updated July 21, 2014, 9:10 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1613 > https://issues.apache.org/jira/browse/MESOS-1613 > > > Repository: mesos-git > > > Description > ------- > > Re-enable HealthCheckTest.ConsecutiveFailures test. > The test originally was flaky because the time to process the number of > consecutive checks configured exceeds the task itself, so the task finished > but the number of expected task health check didn't match. > > > Diffs > ----- > > src/tests/health_check_tests.cpp aa5b78b > > Diff: https://reviews.apache.org/r/23772/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
