> On July 21, 2014, 6:41 p.m., Dominic Hamon wrote:
> > It is good practice to split this change across stout/libprocess/mesos 
> > boundaries.

Thanks for the tip, I split this in three, see : 
https://reviews.apache.org/r/23783/ and https://reviews.apache.org/r/23784/


- Isabel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23749/#review48269
-----------------------------------------------------------


On July 22, 2014, 12:33 a.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23749/
> -----------------------------------------------------------
> 
> (Updated July 22, 2014, 12:33 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Adding missing Apache licence headers on .cpp, .hpp and Makefiles, adding to 
> mesos/support the script I use to make this patch.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am b6464de 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 6fa5b74 
>   3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp deb8df3 
>   3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp 18b2474 
>   3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp 3065278 
>   3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp 4269d3c 
>   3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp d86b0ea 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 3b60ff8 
>   3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 13296d8 
>   3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp eb3abfc 
>   3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 3c4b732 
>   3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 1fa8fc1 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp ee82d15 
>   3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 685a9a1 
>   3rdparty/libprocess/3rdparty/stout/tests/main.cpp 0f1e9cb 
>   3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 79e7200 
>   3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp 425132e 
>   3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 38d25bb 
>   3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 7ae3b8f 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp 4fe3f22 
>   3rdparty/libprocess/3rdparty/stout/tests/os/setns_tests.cpp ff9f10b 
>   3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp ad79a16 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 7fa7346 
>   3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp c723bd7 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 0651185 
>   3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp cdedacd 
>   3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 4041dc4 
>   3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5 
>   3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 7519b12 
>   3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp ad1d986 
> 
> Diff: https://reviews.apache.org/r/23749/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Reply via email to