> On July 22, 2014, 8:38 p.m., Timothy St. Clair wrote: > > src/docker/docker.hpp, line 74 > > <https://reviews.apache.org/r/23771/diff/2/?file=638769#file638769line74> > > > > Graceful termination? How does signal escalation get handled?
This is just an abstraction for Docker kill, in the containerizer we actually do a rm and kill if not removed. > On July 22, 2014, 8:38 p.m., Timothy St. Clair wrote: > > src/docker/docker.hpp, line 37 > > <https://reviews.apache.org/r/23771/diff/2/?file=638769#file638769line37> > > > > So imho we should try to match parity with the API where possible, to > > provide an abstraction which is consistent. > > > > https://docs.docker.com/reference/api/docker_remote_api_v1.13/ > > > > IMHO - It looks more like a cli wrap vs. docker API abstraction. > > > > Perhaps we could open another JIRA after this? Besides the naming of POST/GET containers, I think at least the actions are an interface that we swap out. If we move to the REST api, we are performing the same actions but just callign the REST apis. Ideally we want to use libcontainer though, which if we model after the REST api it's going to look a lot of different in the end IMO. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23771/#review48402 ----------------------------------------------------------- On July 22, 2014, 6:12 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23771/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 6:12 p.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Docker implementation. > This is all the docker code Ben, I and Yifan worked on excluding the > composing containerizer patches. > > > Diffs > ----- > > src/Makefile.am 45afcd1 > src/common/status_utils.hpp 1980551 > src/docker/docker.hpp PRE-CREATION > src/docker/docker.cpp PRE-CREATION > src/examples/docker_no_executor_framework.cpp PRE-CREATION > src/health-check/main.cpp 707810a > src/launcher/executor.cpp 9c80848 > src/linux/cgroups.hpp decad9d > src/linux/cgroups.cpp 6a73dd7 > src/master/master.cpp 251b699 > src/slave/containerizer/containerizer.cpp 1b71f33 > src/slave/containerizer/docker.hpp PRE-CREATION > src/slave/containerizer/docker.cpp PRE-CREATION > src/slave/containerizer/external_containerizer.cpp 3f28d85 > src/slave/containerizer/isolators/cgroups/cpushare.hpp 780037b > src/slave/containerizer/isolators/cgroups/cpushare.cpp 3265a80 > src/slave/containerizer/isolators/cgroups/mem.hpp 8c476c7 > src/slave/containerizer/isolators/cgroups/mem.cpp e8d1e35 > src/slave/containerizer/isolators/posix.hpp 17bbd10 > src/slave/flags.hpp 1fe7b7d > src/slave/slave.cpp f42ab60 > src/tests/docker_containerizer_tests.cpp PRE-CREATION > src/tests/docker_tests.cpp PRE-CREATION > src/tests/environment.cpp 434b3f7 > src/tests/flags.hpp a003e7f > src/tests/mesos_test_executor_docker_image/Dockerfile PRE-CREATION > src/tests/mesos_test_executor_docker_image/install.sh PRE-CREATION > src/tests/script.cpp 15a6542 > src/usage/usage.hpp 5a76746 > src/usage/usage.cpp 29014d1 > > Diff: https://reviews.apache.org/r/23771/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
