-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23771/#review48796
-----------------------------------------------------------
Bad patch!
Reviews applied: [23771]
Failed command: git apply --index 23771.patch
Error:
23771.patch:3554: trailing whitespace.
Try<process::Subprocess> install =
error: patch failed: src/Makefile.am:223
error: src/Makefile.am: patch does not apply
error: patch failed: src/common/status_utils.hpp:24
error: src/common/status_utils.hpp: patch does not apply
error: patch failed: src/slave/containerizer/containerizer.cpp:36
error: src/slave/containerizer/containerizer.cpp: patch does not apply
error: patch failed: src/slave/flags.hpp:339
error: src/slave/flags.hpp: patch does not apply
error: patch failed: src/slave/slave.cpp:2426
error: src/slave/slave.cpp: patch does not apply
- Mesos ReviewBot
On July 22, 2014, 6:12 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23771/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 6:12 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Docker implementation.
> This is all the docker code Ben, I and Yifan worked on excluding the
> composing containerizer patches.
>
>
> Diffs
> -----
>
> src/Makefile.am 45afcd1
> src/common/status_utils.hpp 1980551
> src/docker/docker.hpp PRE-CREATION
> src/docker/docker.cpp PRE-CREATION
> src/examples/docker_no_executor_framework.cpp PRE-CREATION
> src/health-check/main.cpp 707810a
> src/launcher/executor.cpp 9c80848
> src/linux/cgroups.hpp decad9d
> src/linux/cgroups.cpp 6a73dd7
> src/master/master.cpp 251b699
> src/slave/containerizer/containerizer.cpp 1b71f33
> src/slave/containerizer/docker.hpp PRE-CREATION
> src/slave/containerizer/docker.cpp PRE-CREATION
> src/slave/containerizer/external_containerizer.cpp 3f28d85
> src/slave/containerizer/isolators/cgroups/cpushare.hpp 780037b
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 3265a80
> src/slave/containerizer/isolators/cgroups/mem.hpp 8c476c7
> src/slave/containerizer/isolators/cgroups/mem.cpp e8d1e35
> src/slave/containerizer/isolators/posix.hpp 17bbd10
> src/slave/flags.hpp 1fe7b7d
> src/slave/slave.cpp f42ab60
> src/tests/docker_containerizer_tests.cpp PRE-CREATION
> src/tests/docker_tests.cpp PRE-CREATION
> src/tests/environment.cpp 434b3f7
> src/tests/flags.hpp a003e7f
> src/tests/mesos_test_executor_docker_image/Dockerfile PRE-CREATION
> src/tests/mesos_test_executor_docker_image/install.sh PRE-CREATION
> src/tests/script.cpp 15a6542
> src/usage/usage.hpp 5a76746
> src/usage/usage.cpp 29014d1
>
> Diff: https://reviews.apache.org/r/23771/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
