-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23911/
-----------------------------------------------------------
(Updated July 28, 2014, 1:22 p.m.)
Review request for mesos.
Changes
-------
Fixed issue. Thx, Ben M, good call. I also like the more general method better
now. It is very unlikely that there will ever be tasks with the identical ID
that are set up to run with multiple executors at the same time, but let's
program defensively anyway.
Bugs: MESOS-947
https://issues.apache.org/jira/browse/MESOS-947
Repository: mesos-git
Description
-------
Small extension of stout that is useful for fixing MESOS-947, but also in
general. adding a getKey() method to multihashmap, which finds a key given a
value in the map.
A dependent Mesos patch fixing MESOS-947 will follow promptly.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp
ecda6a941077b3e4f9585674b0b5d00d35c5aa1a
Diff: https://reviews.apache.org/r/23911/diff/
Testing
-------
The method behaves as expected in the unit test for MESOS-947. I did not create
stout unit tests for it. (There is no precedence for testing multihashmap and
this particular piece of code is very straightforward.)
Thanks,
Bernd Mathiske
