> On July 25, 2014, 2:20 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp, lines 116-119 > > <https://reviews.apache.org/r/23708/diff/1/?file=636310#file636310line116> > > > > I see that it's doxygen style, but have we agreed on this variant? > > > > Three /'s has the same effect and looks more like the way we do block > > comments. > > > > What do you think, or did I miss a previous discussion?
Doesn't look like anything has happened on MESOS-1186 (doxygen), but I agree that we typically don't like the block comments in Mesos. Although, I understand that switching to '///' won't allow you to fix/evade the style-checker for these comments. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23708/#review48774 ----------------------------------------------------------- On July 19, 2014, 1:51 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23708/ > ----------------------------------------------------------- > > (Updated July 19, 2014, 1:51 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Fix line comments end punctuation in stout > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp > 112dcb1c51315e04267edba2e1e2c86212aeecd6 > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > 43b1bde53bc151344087d6b5e750c13a5b8d246d > 3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp > 88b57979a8bd37c52719b8183aa1f8c5290fcd7c > > Diff: https://reviews.apache.org/r/23708/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
