----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24123/#review49368 -----------------------------------------------------------
Ship it! Are these tests faster given the split? I see this test used to take 10 seconds to run. - Ben Mahler On Aug. 1, 2014, 6:23 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24123/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2014, 6:23 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1655 > https://issues.apache.org/jira/browse/MESOS-1655 > > > Repository: mesos-git > > > Description > ------- > > Fixed a flaky test: ZooKeeperTest.LeaderDetectorTimeoutHandling > > - The original ZK session timeout was the same as AWAIT_READY timeout so it's > possible that AWAIT_READY timed out in a race. > - Split the the test into two and removed the part that waits several seconds > for ZooKeeperTestServer to expire the session which is unnecessary to test > the detector and slows down the test. > > > Diffs > ----- > > src/tests/zookeeper_tests.cpp be9fa06818b96e5170c68810fe16cc472f1f8b28 > > Diff: https://reviews.apache.org/r/24123/diff/ > > > Testing > ------- > > Ran the test for 2000 iterations. > > > Thanks, > > Jiang Yan Xu > >
