-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24197/
-----------------------------------------------------------
(Updated Aug. 1, 2014, 11 p.m.)
Review request for mesos and Ian Downes.
Changes
-------
constant REAPER_PROCESS_WAIT_INTERVAL_MS added to reap.cpp, interval poll time
lowered from 1second to 250milliseconds. This polling interval is driven by
performance testing, see attached file waitpid.pdf.
Bugs: MESOS-1660
https://issues.apache.org/jira/browse/MESOS-1660
Repository: mesos-git
Description
-------
Lower reap interval delay time from 1 second to 250 milliseconds. Constant
REAPER_PROCESS_WAIT_INTERVAL_MS added to highlight/document the change.
Diffs
-----
3rdparty/libprocess/src/reap.cpp b350ee1
Diff: https://reviews.apache.org/r/24197/diff/
Testing
-------
make check
systematic performance testing extending reap_test.cpp to kill N=1,4,16,64,256
child processes and collecting status futures, while continuously varying
REAPER_PROCESS_WAIT_INTERVAL_MS from 1ms to 2seconds - measuring performance on
OS X using XCODE/instruments.
File Attachments (updated)
----------------
Wait Interval vs Child Process Count Performance Study
https://reviews.apache.org/media/uploaded/files/2014/08/01/30b69e3c-12c6-401e-a21f-73de99ae930a__waitpid.pdf
Thanks,
Craig Hansen-Sturm
