----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24286/#review49549 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/24286/#comment86667> This is exposed to the framework, but it's pretty useless to them since it will always be true, right? This change is implying that we'll want to add other invisible resources, do you think that is the case? The operator has to know that they should prefix it with "-" as well? I would be ok with a short term hack that filters "ephemeral_ports" explicitly in the master (with a TODO), seems more straightforward and I don't have a good sense of whether we'll want these invisible resources. - Ben Mahler On Aug. 5, 2014, 12:17 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24286/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 12:17 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1654 > https://issues.apache.org/jira/browse/MESOS-1654 > > > Repository: mesos-git > > > Description > ------- > > Introduced an optional flag 'visible' for resource. Invisible resources are > not exposed to the framework. The idea is that the master will perform > allocation for those resources. > > > Diffs > ----- > > include/mesos/mesos.proto 6d4fd14 > src/common/resources.cpp ade2a71 > src/master/master.cpp 77f2536 > src/tests/mesos.cpp 35c94fa > src/tests/port_mapping_tests.cpp 393b578 > > Diff: https://reviews.apache.org/r/24286/diff/ > > > Testing > ------- > > make check > sudo make check > > > Thanks, > > Jie Yu > >
