> On July 29, 2014, 10:15 p.m., Ben Mahler wrote: > > src/tests/master_tests.cpp, lines 2065-2128 > > <https://reviews.apache.org/r/22796/diff/10/?file=644110#file644110line2065> > > > > I'm not sure we need this test, since it's conflating a few things: > > > > (1) Frameworks do not receive any events from the master after they > > have un-registered, so this is not specific to rescinded offers. > > > > (2) Framework unregistration means that the framework is fully shutdown > > in the cluster, at which point any outstanding offers would be invalid > > (meaning that they are implicitly rescinded). However, we don't send these > > rescinded notifications to the unregistered framework because we completely > > stop communicating with the framework after unregistration. > > > > Does this make sense? Any reason to keep it?
I see, so this should be already been tested by other tests then? I'll remove it. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22796/#review49026 ----------------------------------------------------------- On July 29, 2014, 1:08 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22796/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 1:08 a.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen. > > > Bugs: MESOS-186 > https://issues.apache.org/jira/browse/MESOS-186 > > > Repository: mesos-git > > > Description > ------- > > Based on Kapil's patch (https://reviews.apache.org/r/22066/), adding timeout > for each offer from master to remove the offer when it's no longer used. > > > Diffs > ----- > > src/master/flags.hpp 32704ce > src/master/master.hpp d8a4d9e > src/master/master.cpp 273a516 > src/tests/master_tests.cpp 5a1cf7f > > Diff: https://reviews.apache.org/r/22796/diff/ > > > Testing > ------- > > Added three more unit tests from Kapil's patch: Testing offer not rescinded > after task launched, offer not rescinded when framework/slave unregistered. > The test exposed a race condition that can lead to a segfault if two remove > offers are called on the same offer. > > make check. > > > Thanks, > > Timothy Chen > >
