> On Aug. 6, 2014, 1:20 a.m., Vinod Kone wrote: > > src/tests/environment.cpp, line 154 > > <https://reviews.apache.org/r/24361/diff/1/?file=653355#file653355line154> > > > > We should probably start having a LINUX_ prefix for tests that only run > > on linux (cgroups, docker etc). Maybe a TODO for now.
Sounds good, we can add it later. I wonder if you are going to help commit this, can you run it in your build machine to verify it fixes it? Thanks! - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24361/#review49677 ----------------------------------------------------------- On Aug. 6, 2014, 1:17 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24361/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 1:17 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Fixes the docker validation code that actually checks the docker info status > code. > Also currently we allow either Mac or Linux with root to run docker tests, > however Mac won't even be able to run the tests anyways with the cgroup > validation. > So this patch only allows the tests to run on linux and root. > > > Diffs > ----- > > src/tests/docker_containerizer_tests.cpp > e936e7e52b12a106a2967d03932ea3ca67b9012d > src/tests/docker_tests.cpp 1951d9aa398cdc9ee5c5f83bbc8e23aae4e9b08b > src/tests/environment.cpp eec7d3ed45b32d8f580d231173ba5499761c0bab > > Diff: https://reviews.apache.org/r/24361/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
