----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24343/#review49844 -----------------------------------------------------------
Ship it! src/master/master.hpp <https://reviews.apache.org/r/24343/#comment87234> s/be/being/ src/master/master.cpp <https://reviews.apache.org/r/24343/#comment87238> Would this be simpler if you assign the correct rate limiter (specific or default) first? Option<Owned<BoundedRateLimiter> > limiter; if (use specificLimiter) { limiter = specific limiter; } else if (use defualtLimiter) { limiter = defaultLimiter; } if (limiter.isSome()) { ... } else { _visit(event); } - Vinod Kone On Aug. 7, 2014, 12:25 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24343/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2014, 12:25 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1578 > https://issues.apache.org/jira/browse/MESOS-1578 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 628cce12d2fae645d2ef55e4809631ca03a56207 > src/examples/load_generator_framework.cpp > 7d94c49cf91bf327ac80f04d9f1a7370996b6ba4 > src/master/master.hpp d8a4d9e04ecff60020b99ea6447055787d187797 > src/master/master.cpp 97e4340f7949a261558f09ea533aac0bbb0e40f6 > src/tests/rate_limiting_tests.cpp fc23a1946ad1a78e699552440df2193ea10dc472 > > Diff: https://reviews.apache.org/r/24343/diff/ > > > Testing > ------- > > make check > > ./bin/mesos-tests.sh --verbose --gtest_filter=*RateLimit* --gtest_repeat=1000 > > > Thanks, > > Jiang Yan Xu > >
