----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24485/#review50037 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp <https://reviews.apache.org/r/24485/#comment87548> s/defaults/config/ 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp <https://reviews.apache.org/r/24485/#comment87546> Nasty tossing away const like this... :) - Tobias Weingartner On Aug. 8, 2014, 12:09 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24485/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2014, 12:09 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and > Vinod Kone. > > > Bugs: MESOS-1651 > https://issues.apache.org/jira/browse/MESOS-1651 > > > Repository: mesos-git > > > Description > ------- > > See ticket for details. When parsing flags, users now can specify a file to > be used as defaults. The command line arguments will override the defaults > specified in the configure file. The file is a JSON object: > > { > "flag1" : "string", > "flag2" : true, > "flag3" : 10, > "flag4" : { "a" : 1, "b" : 2} > .. > } > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 112dcb1 > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 3b60ff8 > src/tests/main.cpp 442be51 > > Diff: https://reviews.apache.org/r/24485/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
