----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24511/#review50077 -----------------------------------------------------------
Ship it! I'll file a ticket for exposing the overall failure to destroy a container as a metric. src/linux/cgroups.cpp <https://reviews.apache.org/r/24511/#comment87604> s/freezeTimedout/freezeTimedOut/ ? src/linux/cgroups.cpp <https://reviews.apache.org/r/24511/#comment87605> Expand this comment? Thaw the cgroup before trying to freeze again to allow any pending signals to be delivered. - Ian Downes On Aug. 8, 2014, 2:59 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24511/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2014, 2:59 p.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Bugs: MESOS-1689 > https://issues.apache.org/jira/browse/MESOS-1689 > > > Repository: mesos-git > > > Description > ------- > > See ticket and summary. > > > Diffs > ----- > > src/linux/cgroups.cpp 39a4874 > > Diff: https://reviews.apache.org/r/24511/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
