----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24541/#review50208 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp <https://reviews.apache.org/r/24541/#comment87824> Maybe a small comment about the fact that this supports nesting? Doesn't seem implied from the signature. As another example, this doesn't support indexing: a.b[1].c Kind of reminds me of xpath mapped to json: http://goessner.net/articles/JsonPath/ Should 'key' be renamed to 'path' to suggest the nested nature? 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp <https://reviews.apache.org/r/24541/#comment87826> Seems like this should be an Error() or None() since it's due to invalid input from the caller and we have a Result? - Ben Mahler On Aug. 11, 2014, 7:03 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24541/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2014, 7:03 a.m.) > > > Review request for mesos, Ben Mahler and Timothy Chen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp > 0ce002c1eb269095ba39cf901acaf2687225c464 > 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp > ee82d152b0df5c62188e097aef7b6a335b893285 > > Diff: https://reviews.apache.org/r/24541/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
