----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18489/#review50256 -----------------------------------------------------------
Ship it! Thanks Dominic, a few suggestions: (1) What about a clearer review subject (commit message): 'Changed Result::error() and Try::error() to return const references." (2) Since 'make check' can miss callers that take a const reference that will now go out of scope and become invalid, can you do a visual audit of all the callers before you commit this change? Will you be following through with Future::failure()? Same thing applies there. - Ben Mahler On Aug. 11, 2014, 10:43 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18489/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2014, 10:43 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1147 > https://issues.apache.org/jira/browse/MESOS-1147 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp > 3a10379f13bdf9ff9e6d424ed1877539c30f2731 > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp > d99b75aeae10319b574c67beeb6023358cac7aec > > Diff: https://reviews.apache.org/r/18489/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
