-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24576/#review50263
-----------------------------------------------------------



src/master/master.cpp
<https://reviews.apache.org/r/24576/#comment87951>

    you might want to clear the list or scope it to here. otherwise the 
pointers remain allocated for the remainder of this method.
    
    i doubt it will cause an issue, but i prefer keeping things tightly scoped.
    
    btw - https://reviews.apache.org/r/20423 :)


- Dominic Hamon


On Aug. 11, 2014, 4:32 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24576/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2014, 4:32 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> There were a few cleanups here that I did on the way to MESOS-1620.
> 
> (1) Remove the need for Offer/Task Visitor memory cleanup by using Owned<>.
> (2) Restructured the launch task code to be easier to read and understand.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp e688b41b9f2e555acd8fe0da5d3eb4e8bce32211 
> 
> Diff: https://reviews.apache.org/r/24576/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to