----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24588/#review50341 -----------------------------------------------------------
Probably worth adding some tests. src/docker/docker.cpp <https://reviews.apache.org/r/24588/#comment88034> Here, you are reading the output from 'pull'? Shouldn't you read the output from 'inspect'? - Jie Yu On Aug. 12, 2014, 5:07 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24588/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2014, 5:07 a.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/docker/docker.hpp 98b2d6099988f51f12e7b108e73dcfd0143adc48 > src/docker/docker.cpp 1cba381118c6bd2ac7fcf5a8a229602e2c65c571 > > Diff: https://reviews.apache.org/r/24588/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
