----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24516/#review50371 -----------------------------------------------------------
Ship it! src/master/master.cpp <https://reviews.apache.org/r/24516/#comment88135> i don't think we should because that's a cache and people might un-necessarily depend on it. src/tests/reconciliation_tests.cpp <https://reviews.apache.org/r/24516/#comment88137> update the comment. src/tests/reconciliation_tests.cpp <https://reviews.apache.org/r/24516/#comment88138> update the comment. src/tests/reconciliation_tests.cpp <https://reviews.apache.org/r/24516/#comment88141> update the comment. - Vinod Kone On Aug. 11, 2014, 11:32 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24516/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2014, 11:32 p.m.) > > > Review request for mesos, Niklas Nielsen and Vinod Kone. > > > Bugs: MESOS-1620 > https://issues.apache.org/jira/browse/MESOS-1620 > > > Repository: mesos-git > > > Description > ------- > > We were not surfacing tasks that are pending validation / authorization. > > These are now surfaced as staging tasks > > > Diffs > ----- > > src/master/master.cpp e688b41b9f2e555acd8fe0da5d3eb4e8bce32211 > src/tests/master_authorization_tests.cpp > 5c3557752df86e798ba5d804de588db55ddcfbf6 > src/tests/reconciliation_tests.cpp 952f29b97e7516a3aa69e599901bf49cd2b6d596 > > Diff: https://reviews.apache.org/r/24516/diff/ > > > Testing > ------- > > Updated the existing test. > > I also removed the MasterAuthorizationTest.ReconcileTask test because it was > redundant with ReconciliationTest.PendingTask. > > > Thanks, > > Ben Mahler > >
