> On Aug. 13, 2014, 9:40 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/Makefile.am, lines 87-88 > > <https://reviews.apache.org/r/24628/diff/1/?file=659070#file659070line87> > > > > How is that we didn't need to include these "src" dirs before but have > > to know?
The include changes b/c I had to add a source file redirector 'gmock_sources.cc' due to limitations on SUBST and _SOURCES in automake. > On Aug. 13, 2014, 9:40 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/Makefile.am, line 97 > > <https://reviews.apache.org/r/24628/diff/1/?file=659070#file659070line97> > > > > Pull this below #99? > > > > Also, should this be inside if WITH_BUNDLED_GMOCK ? The file still builds in both cases, so it should not be wrapped in WITH_BUNDLED_GMOCK. > On Aug. 13, 2014, 9:40 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/configure.ac, line 175 > > <https://reviews.apache.org/r/24628/diff/1/?file=659072#file659072line175> > > > > s/#On/# On/ > > > > Also, can you expand on the comment? It's not clear to me why you > > including "stdio.h" here. Is it just a dummy? > > > > Also, where is gtest typically located on system installations? It's a placeholder header for the substitution. gtest on a non-prefixed installation will be in the standard search paths. On epel & Fedora its /usr/lib64 - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24628/#review50494 ----------------------------------------------------------- On Aug. 13, 2014, 2:35 a.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24628/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 2:35 a.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Bugs: MESOS-1171 > https://issues.apache.org/jira/browse/MESOS-1171 > > > Repository: mesos-git > > > Description > ------- > > Enable support to build against unbundled versions of gmock. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 497d038 > 3rdparty/libprocess/3rdparty/gmock_sources.cc.in PRE-CREATION > 3rdparty/libprocess/configure.ac 7b39e63 > configure.ac 8fb0a3a > > Diff: https://reviews.apache.org/r/24628/diff/ > > > Testing > ------- > > configure && make check > configure --disable-bundled && make check > configure --with-gmock=/opt/gmock && make check > > > Thanks, > > Timothy St. Clair > >
