----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24672/#review50513 -----------------------------------------------------------
Ship it! Much appreciated! include/mesos/mesos.proto <https://reviews.apache.org/r/24672/#comment88360> Looks good, maybe we should avoid saying that we will use exec since that's not what we do with docker. Maybe just call out with a note that this is _similar_ to exec? include/mesos/mesos.proto <https://reviews.apache.org/r/24672/#comment88361> I feel like we could do away with the individual comments on 'value' and 'arguments' and just rely on the block comment, might be easier: // There are two ways to specify the command: // (1) shell = true ... // (2) shell = false ... // // NOTE: value became optional in ... optional bool shell = 6 [default = true]; optional string value = 3; repeated string arguments = 7; Otherwise it seems like we are repeating ourselves a bit? - Ben Mahler On Aug. 13, 2014, 9:46 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24672/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 9:46 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Timothy Chen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto dc781d15d3985bf15954a877c7bbd6dbfe2d9094 > src/common/type_utils.cpp 78bfa942f3039d4eda5627d1340231d7110daed9 > src/health-check/main.cpp 68499475520cac3e11b30621ac5684c6e1f8e2cb > src/launcher/executor.cpp 64a41752ee77aa508862194d763dc578aca0c321 > src/slave/containerizer/mesos/launch.cpp > 4e727a1c90b94dbe46fcc23ea37c366472e233ab > src/slave/http.cpp 92eb348707aa256799ebc46142e085107666f894 > src/slave/slave.cpp 59477d57d9f99d61762652fe51ebf2aa770f8d66 > src/tests/health_check_tests.cpp 64fbf629bfdc3ea6c4de7e902bebdea28fdb19b2 > > Diff: https://reviews.apache.org/r/24672/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
