> On Aug. 14, 2014, 5:26 p.m., Ben Mahler wrote: > > Did you test this manually?
Yes I did. I ran the master and sent it SIGTERM with kill. It worked perfectly fine, I don't know why ReviewBot doesn't like it. > On Aug. 14, 2014, 5:26 p.m., Ben Mahler wrote: > > src/logging/logging.cpp, line 75 > > <https://reviews.apache.org/r/24700/diff/1/?file=660530#file660530line75> > > > > Since we're in a signal handler, we have to avoid using system calls > > that are not async signal safe: > > > > http://man7.org/linux/man-pages/man7/signal.7.html > > > > os::user uses sysconf and getpwuid_r, so I think the best we can do > > here is just print the si_uid. ok. - Alexandra ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24700/#review50600 ----------------------------------------------------------- On Aug. 14, 2014, 3:12 p.m., Alexandra Sava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24700/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2014, 3:12 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1567 > https://issues.apache.org/jira/browse/MESOS-1567 > > > Repository: mesos-git > > > Description > ------- > > Log the user id when receiving a SIGTERM. This will make debugging more easy. > > > Diffs > ----- > > src/logging/logging.cpp b05a7e0c3cb5fcdf0ffd8ee7e1bb970bf71622ea > > Diff: https://reviews.apache.org/r/24700/diff/ > > > Testing > ------- > > > Thanks, > > Alexandra Sava > >
