> On Aug. 15, 2014, 6:13 p.m., Ian Downes wrote:
> > docs/network-monitoring.md, line 9
> > <https://reviews.apache.org/r/24719/diff/2/?file=660980#file660980line9>
> >
> >     Perhaps make explicit that they can reach other containers, including 
> > on the same host, and that they can still reach services running on the 
> > localhost of the host <--- This is important because you wouldn't usually 
> > expect this if you had container's running with separate network stacks.

I haven't mentioned network stack yet. Here, just given reader an idea that 
it's completely transparent. I'll way the local host thing later.


> On Aug. 15, 2014, 6:13 p.m., Ian Downes wrote:
> > docs/network-monitoring.md, line 45
> > <https://reviews.apache.org/r/24719/diff/2/?file=660980#file660980line45>
> >
> >     Same public IP and same MAC?
> >     
> >     s/communicate with external world/make connections with other hosts/?
> >     
> >     Are you going to mention about multiple ICMP/ARP replies anywhere?

I don't wanna go into much details here, ICMP/ARP is hard to explain. We can 
have a blog later to explain this.


> On Aug. 15, 2014, 6:13 p.m., Ian Downes wrote:
> > docs/network-monitoring.md, line 52
> > <https://reviews.apache.org/r/24719/diff/2/?file=660980#file660980line52>
> >
> >     Is it not more common to just use `echo "" > /path` while running as 
> > root? People may not be familiar with the tee trick.
> >     
> >     I think you should explain the reasoning and potential impact this 
> > change has. Clarify that this reduces the ephemeral range for any process 
> > that isn't is a container and that it limits the number of connections 
> > based on the 5-tuple and includes TIME_WAIT so highlight that this should 
> > be evaluated for scenarios which have a high number/churn of connections to 
> > services.

I'll leave the reasoning part in the blog.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24719/#review50746
-----------------------------------------------------------


On Aug. 15, 2014, 12:13 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24719/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2014, 12:13 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   docs/network-monitoring.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24719/diff/
> 
> 
> Testing
> -------
> 
> checked the markdown syntax
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to