----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24730/#review50790 -----------------------------------------------------------
Ship it! src/launcher/executor.cpp <https://reviews.apache.org/r/24730/#comment88656> Add a print to indicate it is an override? ```c++ command = "override: " // argv is guaranteed to be NULL terminated and we rely on // that fact to print command to be executed. char** argv = override.get(); for (int i = 0; argv[i] != NULL; i++) { command += ...; } ``` src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/24730/#comment88657> Can you expand a little bit here? Why setting value (not arguments)? - Jie Yu On Aug. 15, 2014, 9:50 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24730/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2014, 9:50 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Allow override without CommandInfo value to run in command executor > > > Diffs > ----- > > src/launcher/executor.cpp 1aa2c99a5e5b19982e99f03d6fbb3bc3d34cea64 > src/tests/docker_containerizer_tests.cpp > e0fd62f83387635f503817ced7a592cc3ae6e775 > > Diff: https://reviews.apache.org/r/24730/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
