-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24755/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Jie Yu.
Repository: mesos-git
Description
-------
These functions tend to read and write "everything" and are often used
with things like Subprocess. A common pattern is that someone will
read from Subprocess::err/out but not hold on to the Subprocess
instance which will cause the underlying file descriptors in
Subprocess to get closed before the io::read/write has completed. To
make this safer, we do what we did with io::redirect and automatically
duplicate the file descriptor.
This was also a good opportunity to remove io::splice from the public
interface since it's not being used and is inherently dangerous.
Diffs
-----
3rdparty/libprocess/include/process/io.hpp
c77529034311ebb0347309ecaa175d2ef1d95208
3rdparty/libprocess/src/process.cpp d403423e6eec4d1d786ab8799ecb03f4decd7b21
3rdparty/libprocess/src/tests/io_tests.cpp
05ea7bb389f670e190be9942b0782ee4cd2e2c08
3rdparty/libprocess/src/tests/subprocess_tests.cpp
98a4e44bd50cd70c908846b71272525e8b5ce406
Diff: https://reviews.apache.org/r/24755/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
