> On Aug. 16, 2014, 4:25 p.m., Jie Yu wrote:
> > src/slave/containerizer/docker.cpp, lines 801-807
> > <https://reviews.apache.org/r/24766/diff/1/?file=662012#file662012line801>
> >
> >     Do you want to chown for fetched stuff as well?

The mesos-fetcher already does that.


> On Aug. 16, 2014, 4:25 p.m., Jie Yu wrote:
> > src/slave/containerizer/docker.cpp, line 802
> > <https://reviews.apache.org/r/24766/diff/1/?file=662012#file662012line802>
> >
> >     You can get rid of the last argument 'true' because the default is 
> > 'true'

Oops, thanks!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24766/#review50823
-----------------------------------------------------------


On Aug. 16, 2014, 4:36 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24766/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2014, 4:36 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp ced0f9247ccb8d1419e464f5c0730b2796ece8e7 
> 
> Diff: https://reviews.apache.org/r/24766/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Reply via email to