> On Aug. 16, 2014, 4:17 p.m., Jie Yu wrote: > > src/tests/docker_containerizer_tests.cpp, line 1449 > > <https://reviews.apache.org/r/24765/diff/2/?file=662118#file662118line1449> > > > > I don't see it being DISABLED?
Oops, forgot to update the review. > On Aug. 16, 2014, 4:17 p.m., Jie Yu wrote: > > src/tests/docker_containerizer_tests.cpp, lines 1550-1573 > > <https://reviews.apache.org/r/24765/diff/2/?file=662118#file662118line1550> > > > > Instead of doing that in this way, I'm wondering can you do > > FUTURE_DISPATCH(slave, Slave::executorLaunched)? YES! Great idea Jie! Soooo much better. Thank you! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24765/#review50822 ----------------------------------------------------------- On Aug. 16, 2014, 2:57 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24765/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2014, 2:57 p.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/docker_containerizer_tests.cpp > 0d7c3b188319768227797d680b0ee8d5f764de10 > > Diff: https://reviews.apache.org/r/24765/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
