----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24700/#review51038 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/glog.hpp <https://reviews.apache.org/r/24700/#comment88915> How about: "Received signal SIGTERM from process %d of user %d; exiting" Can you add an 'if' condition here based on the POSIX documentation: On systems not supporting the XSI option, the si_pid and si_uid members of siginfo_t are only required to be valid when si_code is SI_USER or SI_QUEUE. On XSI-conforming systems, they are also valid for all si_code values less than or equal to 0; however, it is unspecified whether SI_USER and SI_QUEUE have values less than or equal to zero, **and therefore XSI applications should check whether si_code has the value SI_USER or SI_QUEUE or is less than or equal to 0 to tell whether si_pid and si_uid are valid.** - Ben Mahler On Aug. 18, 2014, 11:33 a.m., Alexandra Sava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24700/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2014, 11:33 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1567 > https://issues.apache.org/jira/browse/MESOS-1567 > > > Repository: mesos-git > > > Description > ------- > > Log the user id when receiving a SIGTERM. This will make debugging more easy. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/glog.hpp > 5f763e52a6a3d5a7cb38110ea650283b7a9fa789 > > Diff: https://reviews.apache.org/r/24700/diff/ > > > Testing > ------- > > * make check > * run master binary and send it SIGTERM signal with kill > > > Thanks, > > Alexandra Sava > >
