----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24178/#review51049 -----------------------------------------------------------
src/slave/containerizer/isolators/filesystem.hpp <https://reviews.apache.org/r/24178/#comment88963> __FILESYSTEM_ISOLATOR_HPP__ src/slave/containerizer/isolators/filesystem.cpp <https://reviews.apache.org/r/24178/#comment88965> Should also append the error src/slave/containerizer/isolators/filesystem.cpp <https://reviews.apache.org/r/24178/#comment88964> I think the message should probably reflect that you're also not allowed to mount a parent of the work directory. src/slave/containerizer/isolators/filesystem.cpp <https://reviews.apache.org/r/24178/#comment88966> I believe if it passes realpath it should exist in the file system. - Timothy Chen On Aug. 1, 2014, 6:08 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24178/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2014, 6:08 a.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Bugs: MESOS-1586 > https://issues.apache.org/jira/browse/MESOS-1586 > > > Repository: mesos-git > > > Description > ------- > > Does not report usage or enforce quota but can create 'private' directories > for each container which mask parts of the root filesystem. > > > Diffs > ----- > > src/Makefile.am b660d912c92594ef679b71caf508134f20511dae > src/slave/containerizer/isolators/filesystem.hpp PRE-CREATION > src/slave/containerizer/isolators/filesystem.cpp PRE-CREATION > src/slave/containerizer/linux_launcher.cpp > f3cc813c64e9298f43c9691de9d51ba29c3a8e91 > src/slave/containerizer/mesos/containerizer.cpp > 2c394e2c8702166266f5d20ff005abb218da8a6c > src/slave/flags.hpp 146c4011eb6a64dbb03555cece1c5303338ae240 > src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 > > Diff: https://reviews.apache.org/r/24178/diff/ > > > Testing > ------- > > # added two tests for the FilesystemIsolator > make check > > > Thanks, > > Ian Downes > >
